http://codereview.chromium.org/2864032/diff/31001/32006
File src/isolate.h (right):

http://codereview.chromium.org/2864032/diff/31001/32006#newcode825
src/isolate.h:825: #if defined(V8_TARGET_ARCH_ARM) && !defined(__arm__)
code probably would benefit from class ArmSimulator with this stuff

http://codereview.chromium.org/2864032/diff/31001/32007
File src/platform-linux.cc (right):

http://codereview.chromium.org/2864032/diff/31001/32007#newcode864
src/platform-linux.cc:864: static Mutex* dtoa_lock_zero =
OS::CreateMutex();
Why we need several ACQUIRE_DTOA_LOCK / FREE_DTOA_LOCK with the same
code? The code itself should work for Windows/ other platforms too :)

http://codereview.chromium.org/2864032/show

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to