On 2010/07/01 21:10:07, Vitaly wrote:
http://codereview.chromium.org/2864032/diff/31001/32003 File src/arm/simulator-arm.h (right):
http://codereview.chromium.org/2864032/diff/31001/32003#newcode345 src/arm/simulator-arm.h:345: return assembler::arm::Simulator::current(v8::internal::Isolate::Current()) nit: Split the line before "v8".
http://codereview.chromium.org/2864032/diff/31001/32007 File src/platform-linux.cc (right):
http://codereview.chromium.org/2864032/diff/31001/32007#newcode872 src/platform-linux.cc:872: void ACQUIRE_DTOA_LOCK(int n) { Move these functions to dtoa-config.c. Nothing platform-dependent here.
I think I got these. I couldn't move those functions into dtoa-config.c because they do things C doesn't care for, so I dropped them in conversions.cc instead
(which I thought was the nearest logical place for them). Thanks! http://codereview.chromium.org/2864032/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
