LGTM with a few nits.
http://codereview.chromium.org/2864032/diff/16003/49004 File src/arm/simulator-arm.cc (right): http://codereview.chromium.org/2864032/diff/16003/49004#newcode499 src/arm/simulator-arm.cc:499: void Simulator::FlushICache(v8::internal::HashMap* i_cache, void* start_addr, nit: One arg per line. http://codereview.chromium.org/2864032/diff/16003/49004#newcode534 src/arm/simulator-arm.cc:534: void Simulator::FlushOnePage(v8::internal::HashMap* i_cache, intptr_t start, Ditto. http://codereview.chromium.org/2864032/diff/16003/49006 File src/conversions.cc (right): http://codereview.chromium.org/2864032/diff/16003/49006#newcode1165 src/conversions.cc:1165: void ACQUIRE_DTOA_LOCK(int n) { ASSERT(n == 0 || n == 1) http://codereview.chromium.org/2864032/diff/16003/49006#newcode1171 src/conversions.cc:1171: (n == 0 ? v8::internal::dtoa_lock_zero : v8::internal::dtoa_lock_one)-> Ditto. http://codereview.chromium.org/2864032/diff/16003/49007 File src/dtoa-config.c (right): http://codereview.chromium.org/2864032/diff/16003/49007#newcode88 src/dtoa-config.c:88: /* Definitions for dtoa's ACQUIRE_DTOA_LOCK and FREE_DTOA_LOCK are in Thanks for adding this comment. http://codereview.chromium.org/2864032/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
