A couple of tiny nits...
http://codereview.chromium.org/2910004/diff/1/11 File src/isolate.cc (right): http://codereview.chromium.org/2910004/diff/1/11#newcode167 src/isolate.cc:167: //////////////////////////////////////////////////////////////////////////////// I believe these comments are not blessed by any style guide... http://codereview.chromium.org/2910004/diff/1/12 File src/isolate.h (right): http://codereview.chromium.org/2910004/diff/1/12#newcode401 src/isolate.h:401: static bool EnsureStaticInitialized(); If it is ensuring the default isolate is initialized, maybe better name would be EnsureDefaultIsolateInitialized()? The fact that it is [usually] called during static initialization is a bit separate. http://codereview.chromium.org/2910004/diff/1/12#newcode406 src/isolate.h:406: static Thread::LocalStorageKey* isolate_key() { These perhaps can just return Thread::LocalStorageKey rather then a pointer. It's always a simple type. http://codereview.chromium.org/2910004/diff/1/12#newcode425 src/isolate.h:425: ////////////////////////////////////////////////////////////////////////////// remove this comment? http://codereview.chromium.org/2910004/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
