More nits.
http://codereview.chromium.org/2910004/diff/1/11 File src/isolate.cc (right): http://codereview.chromium.org/2910004/diff/1/11#newcode244 src/isolate.cc:244: Isolate* Isolate::Create(Deserializer* des) { Can we rename it to InitializeDefaultIsolate() since this is what it actually does. Also, we might have Isolate::default_isolate() as well, to avoid hiding accessor into 'convinient' return of this method. http://codereview.chromium.org/2910004/diff/1/11#newcode262 src/isolate.cc:262: Isolate* Isolate::TryToImplicitlyEnterDefaultIsolate() { Why is it named TryTo*? It seems it always enters default isolate... I would rename InitOnce into EnsureDefaultIsolate, and call that from this function. The check and locj can go there as well. This is also the only place we call InitOnce. http://codereview.chromium.org/2910004/diff/1/11#newcode263 src/isolate.cc:263: // TODO(isolates): Check that we're not in multiple-isolate mode. Could you please clarify what should be checked here? If other thread creates an isolate a millisecond later, whats' going to be wrong? http://codereview.chromium.org/2910004/diff/1/11#newcode287 src/isolate.cc:287: //////////////////////////////////////////////////////////////////////////////// more separators, more places in this file. http://codereview.chromium.org/2910004/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
