LGTM with a small renaming comment.
As I can see all the comments of Vitaly and me are addressed. It would be
cool
to have Vitaly to take the final look, but since we are stuck on this
change for
further APi and perf work, lets:
a) ask Mads to take a final look if he wants to
b) land it tomorrow! :-)
http://codereview.chromium.org/2910004/diff/31/39011
File src/isolate.h (right):
http://codereview.chromium.org/2910004/diff/31/39011#newcode408
src/isolate.h:408: static Isolate* TryToImplicitlyEnterDefaultIsolate();
From what this method does, it should be called EnterDefaultIsolate().
"Try" usually assumes it can fail and return a result that is
subsequently checked and acted upon, which is not the case here. Also,
"Implicit" is a reflection of type of the usage in a particular callsite
rather then what the method does.
http://codereview.chromium.org/2910004/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
