http://codereview.chromium.org/3047027/diff/16001/17003 File src/heap.cc (right):
http://codereview.chromium.org/3047027/diff/16001/17003#newcode328 src/heap.cc:328: ASSERT(gc_allowed_); maybe at the very start of the method? http://codereview.chromium.org/3047027/diff/16001/17006 File src/ic.cc (right): http://codereview.chromium.org/3047027/diff/16001/17006#newcode574 src/ic.cc:574: AssertNoGC nogc; // GC could invalidate the pointers held in lookup. I agree with Vitaly here (if I understand him correctly): why not at the very start of the function? Same for all other functions. http://codereview.chromium.org/3047027/diff/16001/17006#newcode1483 src/ic.cc:1483: AssertNoGC nogc; // GC could invalidate the pointers held in lookup. why not change ::Load/Store methods as well like: LookupResult lookup; { AssertNoGc nogc; LookupForRead(...); ... } PropertyAttributes attr; Object* result = object->GetProperty(...) ? That would allow us to catch additional problems. http://codereview.chromium.org/3047027/diff/16001/17008 File src/stub-cache.h (right): http://codereview.chromium.org/3047027/diff/16001/17008#newcode688 src/stub-cache.h:688: // exist and cannot be created without causing GC. nit: maybe don't overspecify: returns Failure if jump to miss stub cannot be generated? by no means insisting. http://codereview.chromium.org/3047027/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
