LGTM.
http://codereview.chromium.org/3047027/diff/16001/17003 File src/heap.cc (right): http://codereview.chromium.org/3047027/diff/16001/17003#newcode328 src/heap.cc:328: ASSERT(gc_allowed_); On 2010/08/04 14:29:20, Vladislav Kaznacheev wrote:
Cannot see much difference.
On 2010/07/30 17:18:57, antonm wrote: > maybe at the very start of the method?
You won't clean any caches. The mantra is to catch error as early as possible. Not insisting. http://codereview.chromium.org/3047027/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
