http://codereview.chromium.org/3047027/diff/1/2
File src/arm/stub-cache-arm.cc (right):

http://codereview.chromium.org/3047027/diff/1/2#newcode1292
src/arm/stub-cache-arm.cc:1292: Object* branch = GenerateMissBranch();
Well, the generator function doesn't return the branch code (in fact, it
really can't since the branch is part of the current code object). The
contract here is that if it returned a failure, it must be propagated.
Something like this:
Object* obj = GenerateMissBranch();
if (obj->IsFailure()) return obj;

http://codereview.chromium.org/3047027/show

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to