LGTM
http://codereview.chromium.org/3446024/diff/11001/12002 File src/ia32/stub-cache-ia32.cc (right): http://codereview.chromium.org/3446024/diff/11001/12002#newcode2016 src/ia32/stub-cache-ia32.cc:2016: __ mov(ebx, FieldOperand(eax, HeapNumber::kExponentOffset)); You could potentially use an xmm register here and do (assume loaded into xmm0): pxor(xmm1, xmm1); subsd(xmm1, xmm0) and(xmm0, xmm1) http://codereview.chromium.org/3446024/diff/11001/12006 File test/mjsunit/math-abs.js (right): http://codereview.chromium.org/3446024/diff/11001/12006#newcode28 test/mjsunit/math-abs.js:28: // Flags: --max-new-space-size=262144 Why this flag? http://codereview.chromium.org/3446024/diff/11001/12006#newcode78 test/mjsunit/math-abs.js:78: assertEquals(two_30 - 1, Math.abs(-two_30 + 1)); Maybe add a few test cases where you call Math.abs on objects, arrays and strings that are not actual numbers (to test that we do indeed bail out if this is the case) http://codereview.chromium.org/3446024/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
