http://codereview.chromium.org/3446024/diff/11001/12001#newcode1720 > src/arm/stub-cache-arm.cc:1720: __ tst(r1, r3); > On 2010/09/27 14:17:23, Rodolph Perfetta wrote: > > merge the mov with the tst: tst(r1, Operand(HeapNumber::kSignMask)). > > > > You will need to do the same for the eor further down. > > Will the constant fit into the instruction? I was afraid of using the > constant > pool more than necessary, but maybe it's not an issue. > > I wasn't clear in my previous reply, for non relocatable immediate V8 assembler can inline constant in the code using movw/movt. This does increase the code size but release pressure on the D side (no constant pool entry required). Of course the less code the better, but as said before the constant fits.
-- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
