http://codereview.chromium.org/3446024/diff/11001/12001 File src/arm/stub-cache-arm.cc (right):
http://codereview.chromium.org/3446024/diff/11001/12001#newcode1699 src/arm/stub-cache-arm.cc:1699: __ sub(r0, r0, r1); Did you mean sub(r0, r0, r1, SetCC) ? Also wouldn't the sequence: cmp r0, #0 rsbmis r0, r0, #0 bmi slow be better for an integer abs (or did I miss a smi corner case?) http://codereview.chromium.org/3446024/diff/11001/12001#newcode1720 src/arm/stub-cache-arm.cc:1720: __ tst(r1, r3); merge the mov with the tst: tst(r1, Operand(HeapNumber::kSignMask)). You will need to do the same for the eor further down. http://codereview.chromium.org/3446024/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
