I measured small boost (about 2.5% on DOM queries that is bigger than
variations
~0.45% though). It's smaller than I previously measured on Lin64 before
fixing
the bug with exceptions, but not this CL fixed the bug what is good.
http://codereview.chromium.org/3792003/diff/43019/13032
File src/ia32/macro-assembler-ia32.h (right):
http://codereview.chromium.org/3792003/diff/43019/13032#newcode484
src/ia32/macro-assembler-ia32.h:484: // returned value from handle and
propogates exceptions.
On 2010/10/18 12:45:29, antonm wrote:
maybe add some words about what this macro expects in regard of stack,
parameter
passing, etc.
Done.
http://codereview.chromium.org/3792003/diff/43019/13038
File src/x64/macro-assembler-x64.cc (right):
http://codereview.chromium.org/3792003/diff/43019/13038#newcode518
src/x64/macro-assembler-x64.cc:518: // rsi is only callee-save on Win64.
On other platforms it must be restored.
On 2010/10/18 12:45:29, antonm wrote:
as was discussed offline, that's not the best explanation why it is
allowed not
to restore base_reg on Win64
The comment rewritten.
http://codereview.chromium.org/3792003/diff/43019/13039
File src/x64/macro-assembler-x64.h (right):
http://codereview.chromium.org/3792003/diff/43019/13039#newcode824
src/x64/macro-assembler-x64.h:824: void TailCallApiFunction(ApiFunction*
function, int stack_space);
On 2010/10/18 12:45:29, antonm wrote:
Ditto for better documentation
Done.
http://codereview.chromium.org/3792003/show
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
