http://codereview.chromium.org/3792003/diff/78001/79011 File src/ia32/macro-assembler-ia32.cc (right):
http://codereview.chromium.org/3792003/diff/78001/79011#newcode1101 src/ia32/macro-assembler-ia32.cc:1101: mov(Operand(esp, 0 * kPointerSize), ebx); // name. I don't think that belongs here---it should be on caller side. I think call api function should only call api function and analyse the result. And I don't quite understand why it's named TailCall http://codereview.chromium.org/3792003/diff/78001/79012 File src/ia32/macro-assembler-ia32.h (right): http://codereview.chromium.org/3792003/diff/78001/79012#newcode486 src/ia32/macro-assembler-ia32.h:486: // eax - pointer to accessor_info. Sorry, I missed that in review, but that's not good imho: TailCallApiFunction should be generic, not to call accessors (otherwise it should be named so), see comment in macro-assembler-ia32.cc http://codereview.chromium.org/3792003/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
