LGTM
http://codereview.chromium.org/3792003/diff/123001/80017 File src/ia32/macro-assembler-ia32.cc (right): http://codereview.chromium.org/3792003/diff/123001/80017#newcode1121 src/ia32/macro-assembler-ia32.cc:1121: mov(Operand(esp, (argc + 1) * kPointerSize), Immediate(0)); // out cell. On 2010/10/21 13:04:06, SeRya wrote:
On 2010/10/21 11:52:38, antonm wrote: > couldn't you use mov(Operand(eax, 0), Immediate(0)); instead?
Sure we could. It would save one byte of code but wouldn't it
introduce data
dependence?
Up to you. Given you have eax dependency above and doing tons of additional stuff below, I'd be surprised if it matters. http://codereview.chromium.org/3792003/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
