A couple more drive-bys, they apply to the other platforms as well.
http://codereview.chromium.org/4004006/diff/18001/19001 File src/arm/codegen-arm.cc (right): http://codereview.chromium.org/4004006/diff/18001/19001#newcode3640 src/arm/codegen-arm.cc:3640: frame_->Pop(); There is a VirtualFrame::Drop function that can be used to drop multiple elements and probably emits better code. You should also use it above to signify that you intend to ignore the return value. http://codereview.chromium.org/4004006/diff/18001/19002 File src/arm/full-codegen-arm.cc (right): http://codereview.chromium.org/4004006/diff/18001/19002#newcode39 src/arm/full-codegen-arm.cc:39: #include "codegen.h" This is probably not needed here either. http://codereview.chromium.org/4004006/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
