http://codereview.chromium.org/4004006/diff/18001/19001
File src/arm/codegen-arm.cc (right):

http://codereview.chromium.org/4004006/diff/18001/19001#newcode3640
src/arm/codegen-arm.cc:3640: frame_->Pop();
On 2010/10/26 12:31:18, Kevin Millikin wrote:
There is a VirtualFrame::Drop function that can be used to drop
multiple
elements and probably emits better code.

You should also use it above to signify that you intend to ignore the
return
value.

Done.

http://codereview.chromium.org/4004006/diff/18001/19002
File src/arm/full-codegen-arm.cc (right):

http://codereview.chromium.org/4004006/diff/18001/19002#newcode39
src/arm/full-codegen-arm.cc:39: #include "codegen.h"
On 2010/10/26 12:31:18, Kevin Millikin wrote:
This is probably not needed here either.
That is true. Removed.

http://codereview.chromium.org/4004006/show

--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev

Reply via email to