http://codereview.chromium.org/4004006/diff/18001/19003 File src/ast.cc (right):
http://codereview.chromium.org/4004006/diff/18001/19003#newcode184 src/ast.cc:184: bool IsEqual(void* first, void* second) { On 2010/10/26 13:53:54, Mads Ager wrote:
I think you should split this into two functions. StringEquals and
SmiEquals.
Then you don't need the conditionals here.
Done. http://codereview.chromium.org/4004006/diff/18001/19003#newcode204 src/ast.cc:204: for (int i = this->properties()->length()-1; i >= 0; i--) { On 2010/10/26 13:53:54, Mads Ager wrote:
Space before and after '-'. Consider pulling out the length extraction
from the
for loop.
Done. http://codereview.chromium.org/4004006/diff/18001/19003#newcode238 src/ast.cc:238: // If the key of a computed property is in the table, mark the property. On 2010/10/26 13:53:54, Mads Ager wrote:
mark the property -> do not emit a store for the property.
Done. http://codereview.chromium.org/4004006/show -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
