http://codereview.chromium.org/5107002/diff/1/src/arm/stub-cache-arm.cc File src/arm/stub-cache-arm.cc (right):
http://codereview.chromium.org/5107002/diff/1/src/arm/stub-cache-arm.cc#newcode1084 src/arm/stub-cache-arm.cc:1084: __ push(receiver); // Receiver nit: probably change R -> r as you remove a dot. http://codereview.chromium.org/5107002/diff/1/src/arm/stub-cache-arm.cc#newcode1085 src/arm/stub-cache-arm.cc:1085: __ mov(ip, Operand(Handle<AccessorInfo>(callback))); // callback data why such a change, __ Push(reg, ip, name_reg) apparently should have done the trick, what am I missing http://codereview.chromium.org/5107002/diff/1/src/arm/stub-cache-arm.cc#newcode1211 src/arm/stub-cache-arm.cc:1211: __ ldr(scratch3, why scratch3? it looks like the diff might be made easier to read by something like: __ Push(receiver, holder_reg); __ ldr(....) __ Push(.......) http://codereview.chromium.org/5107002/diff/1/src/builtins.cc File src/builtins.cc (left): http://codereview.chromium.org/5107002/diff/1/src/builtins.cc#oldcode1102 src/builtins.cc:1102: custom.end(), do we use CustomArguments? ::end()? http://codereview.chromium.org/5107002/diff/1/src/builtins.cc File src/builtins.cc (right): http://codereview.chromium.org/5107002/diff/1/src/builtins.cc#newcode1091 src/builtins.cc:1091: Handle<JSFunction> function = args.at<JSFunction>(args_length); maybe move this check after new_args construction and use new_args.Callee() and new_args.This()? http://codereview.chromium.org/5107002/diff/1/test/cctest/test-api.cc File test/cctest/test-api.cc (right): http://codereview.chromium.org/5107002/diff/1/test/cctest/test-api.cc#newcode7019 test/cctest/test-api.cc:7019: CHECK_EQ(args.Data(), v8_str("method_data")); nit: indent http://codereview.chromium.org/5107002/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
