LGTM with comment addressed
http://codereview.chromium.org/5107002/diff/1/src/builtins.cc File src/builtins.cc (right): http://codereview.chromium.org/5107002/diff/1/src/builtins.cc#newcode1091 src/builtins.cc:1091: Handle<JSFunction> function = args.at<JSFunction>(args_length); On 2010/11/17 15:36:29, SeRya wrote:
On 2010/11/17 14:10:32, antonm wrote: > maybe move this check after new_args construction and use
new_args.Callee()
and > new_args.This()?
new_args.Callee() is v8::Handle. Do you think it worth to convert it
back and
forth?
I don't think we care in debug mode. And those handles should be ephemeral if memory serves: just a pointer inside an array of which GC is aware http://codereview.chromium.org/5107002/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
