I found a bug in prev CL, so please review again.
http://codereview.chromium.org/5107002/diff/10001/src/arm/stub-cache-arm.cc File src/arm/stub-cache-arm.cc (right): http://codereview.chromium.org/5107002/diff/10001/src/arm/stub-cache-arm.cc#newcode1212 src/arm/stub-cache-arm.cc:1212: FieldMemOperand(holder_reg, AccessorInfo::kDataOffset)); Using holder_reg with AccessorInfo::kDataOffset doesn't make sence, but previously this value was ignored (callback->data() was used instead). When I begun to use this field the bug was not discovered because tests what cover this code didn't check Data() field. So I added such a check into test-api.cc. http://codereview.chromium.org/5107002/diff/1008/src/builtins.cc File src/builtins.cc (right): http://codereview.chromium.org/5107002/diff/1008/src/builtins.cc#newcode1099 src/builtins.cc:1099: #endif On 2010/11/18 11:36:08, antonm wrote:
On 2010/11/17 15:36:29, SeRya wrote: > On 2010/11/17 14:10:32, antonm wrote: > > maybe move this check after new_args construction and use
new_args.Callee()
> and > > new_args.This()? > > new_args.Callee() is v8::Handle. Do you think it worth to convert it
back and
> forth?
I don't think we care in debug mode. And those handles should be
ephemeral if
memory serves: just a pointer inside an array of which GC is aware
Done. Actually it was a bug here (|function| was at a wrong place). I fixed it and added type check into apiutils.h. Thank you for the comment. http://codereview.chromium.org/5107002/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
