[v8-dev] Re: Use correct calling convention for API calls on MinGW (issue5699003)

[erik . corry]

lgtm


http://codereview.chromium.org/5699003/diff/2001/src/ia32/macro-assembler-ia32.cc
File src/ia32/macro-assembler-ia32.cc (right):

http://codereview.chromium.org/5699003/diff/2001/src/ia32/macro-assembler-ia32.cc#newcode1225
src/ia32/macro-assembler-ia32.cc:1225: #if defined(USING_BSD_ABI) ||
defined(__MINGW32__)
On 2010/12/09 19:35:34, antonm wrote:

I'd rather moved defined(__MINGW32__) into src/globals.h where

USING_BSD_ABI is

defined

 I agree with Anton.

http://codereview.chromium.org/5699003/diff/2001/src/ia32/macro-assembler-ia32.cc#newcode1233
src/ia32/macro-assembler-ia32.cc:1233: return Operand(esp, (index +
(kReturnHandlesDirectly ? 0 : 1)) * kPointerSize);
lint?

http://codereview.chromium.org/5699003/

--
v8-dev mailing list
v8-dev@googlegroups.com
http://groups.google.com/group/v8-dev