http://codereview.chromium.org/5699003/diff/2001/src/ia32/macro-assembler-ia32.cc File src/ia32/macro-assembler-ia32.cc (right):
http://codereview.chromium.org/5699003/diff/2001/src/ia32/macro-assembler-ia32.cc#newcode1225 src/ia32/macro-assembler-ia32.cc:1225: #if defined(USING_BSD_ABI) || defined(__MINGW32__) On 2010/12/10 11:35:20, Erik Corry wrote:
On 2010/12/09 19:35:34, antonm wrote: > I'd rather moved defined(__MINGW32__) into src/globals.h where
USING_BSD_ABI
is > defined I agree with Anton.
I committed as is. I do not think that defining USING_BSD_ABI for __MINGW32__ is correct thing. (name is misleading). http://codereview.chromium.org/5699003/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
