Reviewers: Evan Martin,
Message:
As the CL description says it is possible to build all our targets on Intel
Linux for all architectures (ia32, x64 and ARM simulator).
Evan:
The way I try to determine the host architecture in common.gypi does not
work, I
have to do
$ GYP_DEFINES=target_arch=ia32; build/gyp_v8
or
$ GYP_DEFINES=target_arch=x64; build/gyp_v8
Also in cctest.gyp I have some stuff which is duplicated in v8.gyp. Will the
best refactoring be to move taht to an include (e.g. arch_defines.gypi)?
Mads:
What do you think?
http://codereview.chromium.org/5701001/diff/1/build/common.gypi
File build/common.gypi (right):
http://codereview.chromium.org/5701001/diff/1/build/common.gypi#newcode56
build/common.gypi:56: },{'target_defaults': {'ccflags':['-xxx']}}],
On 2010/12/09 22:03:13, Evan Martin wrote:
I'd rewrite this line as
}, { # else: not linux
'target_defaults': {'ccflags':['-xxx']}
}],
This was testing leftovers, removed.
http://codereview.chromium.org/5701001/diff/1/tools/gyp/samples.gyp
File tools/gyp/samples.gyp (right):
http://codereview.chromium.org/5701001/diff/1/tools/gyp/samples.gyp#newcode44
tools/gyp/samples.gyp:44: # This could be gotten by not setting
chromium_code, if that's OK.
On 2010/12/09 22:03:13, Evan Martin wrote:
We normally only set chromium_code for code that is in the chromium
tree. Since
v8 better knows its build settings, I think it can leave chromium_code
at 0.
Done.
Description:
Initial attempt to add support for using gyp to build V8 itself
This is based on the structore used in chromium with a script wrapping the
call
to gyp itself and the default processing of common.gypi.
It is possible to build all our targets on Intel Linux for all architectures
(ia32, x64 and ARM simulator). When this is committed I wil take a look at
Windows.
See the README.txt file in the changelist for the current way of using it.
Please review this at http://codereview.chromium.org/5701001/
SVN Base: http://v8.googlecode.com/svn/branches/bleeding_edge/
Affected files:
A build/README.txt
A build/all.gyp
A build/armu.gypi
A build/common.gypi
A build/gyp_v8
A samples/samples.gyp
A src/d8.gyp
A test/cctest/cctest.gyp
M tools/gyp/v8.gyp
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
