LGTM
I would be fine with committing this as a work in progress. We need to make
it
easier to use before switching to it for real. Switching completely to gyp
generated build files would be great.
http://codereview.chromium.org/5701001/diff/18001/build/README.txt
File build/README.txt (right):
http://codereview.chromium.org/5701001/diff/18001/build/README.txt#newcode12
build/README.txt:12: To generate Makefiles and build 32-bit version on
Linux:
As we just discussed offline I think it would be nice for V8 if we can
simply create a Makefile (VS project, XCode project) that contains
targets for shell-ia32 shell-x64 and shell-sim-arm. This way you don't
have to deal with the GYP_DEFINES.
I'm fine with doing this as a followup change though.
http://codereview.chromium.org/5701001/diff/18001/build/gyp_v8
File build/gyp_v8 (right):
http://codereview.chromium.org/5701001/diff/18001/build/gyp_v8#newcode3
build/gyp_v8:3: # Copyright 2008 the V8 project authors. All rights
reserved.
2010
http://codereview.chromium.org/5701001/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
