I agree with Mads, this LGTM
http://codereview.chromium.org/5701001/diff/18001/build/common.gypi File build/common.gypi (right): http://codereview.chromium.org/5701001/diff/18001/build/common.gypi#newcode65 build/common.gypi:65: 'cflags': [ '-Wall', '-pthread', '-fno-rtti', '-fno-exceptions'], space before ] for symmetry http://codereview.chromium.org/5701001/diff/18001/tools/gyp/v8.gyp File tools/gyp/v8.gyp (right): http://codereview.chromium.org/5701001/diff/18001/tools/gyp/v8.gyp#newcode650 tools/gyp/v8.gyp:650: '-lpthread', I always get this wrong, but I have the vague recollection that there a -pthread flag that passes -lpthread as well as set some other settings... http://codereview.chromium.org/5701001/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
