hi Mads, This code change is not enabled for the simulator (pls refer to ifdefs in stub-cache-arm.cc) so it works exactly as before. In the next CL i will add support for direct call through simulator. Does that sound OK?
thanks, Zaheer On Thu, Jan 20, 2011 at 4:26 PM, Mads Sig Ager <[email protected]> wrote: > Drive-by: we cannot land this change without support for the > simulator. Everything committed needs to work in a simulator build. > > Thanks, -- Mads > > On Thu, Jan 20, 2011 at 11:52 AM, <[email protected]> wrote: > > Please review the uploaded change. > > - use intermediate stub to support stub code movement (option a) from > > previous > > comments) > > - removed EnterExitFramePrologue/Epilogue as epilogue is thin now > > > > support for simulator will be a separate CL. > > Thanks. > > > > http://codereview.chromium.org/6170001/ > > > > -- > v8-dev mailing list > [email protected] > http://groups.google.com/group/v8-dev > -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
