Thank you for the simplifying the exit fame. LGTM with a few comments.
http://codereview.chromium.org/6170001/diff/65002/src/arm/frames-arm.h File src/arm/frames-arm.h (right): http://codereview.chromium.org/6170001/diff/65002/src/arm/frames-arm.h#newcode116 src/arm/frames-arm.h:116: static const int kMarkerOffset = -2 * kPointerSize; Actually the same technique (used fixed place in the stack frame for the return address) could be used to avoid this marker (and simplify exit frame layout). I don't think it worth to do it in this CL but you can update this TODO. http://codereview.chromium.org/6170001/diff/65002/src/arm/macro-assembler-arm.cc File src/arm/macro-assembler-arm.cc (right): http://codereview.chromium.org/6170001/diff/65002/src/arm/macro-assembler-arm.cc#newcode1401 src/arm/macro-assembler-arm.cc:1401: EnterExitFrame(false, arg_stack_space + 5); +1? http://codereview.chromium.org/6170001/diff/65002/src/arm/simulator-arm.cc File src/arm/simulator-arm.cc (right): http://codereview.chromium.org/6170001/diff/65002/src/arm/simulator-arm.cc#newcode1590 src/arm/simulator-arm.cc:1590: SimulatorRuntimeApiCall target = May be to add ASSERT that where is indeed one argument? PrepareCallApiFunction looks quite general, but in simulator only one argument is actually passed. http://codereview.chromium.org/6170001/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
