http://codereview.chromium.org/6170001/diff/90001/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right):
http://codereview.chromium.org/6170001/diff/90001/src/arm/code-stubs-arm.cc#newcode2723 src/arm/code-stubs-arm.cc:2723: __ mov(r5, Operand(r1)); I don't see the benefit of moving this outside the EnterExitFrame, but if you are going to do it then you should update the comment in macro-assembler-arm.h. http://codereview.chromium.org/6170001/diff/90001/src/arm/macro-assembler-arm.h File src/arm/macro-assembler-arm.h (right): http://codereview.chromium.org/6170001/diff/90001/src/arm/macro-assembler-arm.h#newcode259 src/arm/macro-assembler-arm.h:259: // |stack_space| pending pushes, used for alignment before call to C. We haven't used this |parameter_name| style elsewhere as far as I can see. Also, this comment has not been updated to reflect that the ip has sp that should be restored. Also the comment is out of date because it mentions r6 as being set up by the EnterExitFrame, whereas in fact it needs to be set up by the caller. http://codereview.chromium.org/6170001/diff/90001/src/arm/simulator-arm.cc File src/arm/simulator-arm.cc (right): http://codereview.chromium.org/6170001/diff/90001/src/arm/simulator-arm.cc#newcode800 src/arm/simulator-arm.cc:800: void* external_function, bool fp_return, ExternalReference::Type type) { You shouldn't need both the bool for the fp_return and the external reference type. They can both be folded into the external reference type. http://codereview.chromium.org/6170001/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
