Nice and thanks.
http://codereview.chromium.org/6390003/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): http://codereview.chromium.org/6390003/diff/1/src/hydrogen.cc#newcode3524 src/hydrogen.cc:3524: int context_chain_length = should we refactor the code that builds context values chain into a helper method? http://codereview.chromium.org/6390003/diff/1/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): http://codereview.chromium.org/6390003/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode1934 src/ia32/lithium-codegen-ia32.cc:1934: Operand(context, Context::SlotOffset(Context::FCONTEXT_INDEX))); maybe introduce additional instruction for this load not to repeat on each slot load/store? http://codereview.chromium.org/6390003/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode2184 src/ia32/lithium-codegen-ia32.cc:2184: __ mov(result, esi); Can we make it noop by requesting the result register to be esi? http://codereview.chromium.org/6390003/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
