LGTM.
http://codereview.chromium.org/6390003/diff/1/src/hydrogen-instructions.h File src/hydrogen-instructions.h (right): http://codereview.chromium.org/6390003/diff/1/src/hydrogen-instructions.h#newcode2645 src/hydrogen-instructions.h:2645: virtual Representation RequiredInputRepresentation(int index) const { I think we are not consistent with when to override this function. Until now we left the default implementation (Representation::None) for cases where we don't ever expect a conversion of the inputs. http://codereview.chromium.org/6390003/diff/1/src/ia32/lithium-codegen-ia32.cc File src/ia32/lithium-codegen-ia32.cc (right): http://codereview.chromium.org/6390003/diff/1/src/ia32/lithium-codegen-ia32.cc#newcode2184 src/ia32/lithium-codegen-ia32.cc:2184: __ mov(result, esi); On 2011/01/27 14:00:07, antonm wrote:
Can we make it noop by requesting the result register to be esi?
esi will be replaced by [fixed-stack-slot] - so i'd leave it as is for now. http://codereview.chromium.org/6390003/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
