http://codereview.chromium.org/6390003/diff/1/src/hydrogen-instructions.h
File src/hydrogen-instructions.h (right):
http://codereview.chromium.org/6390003/diff/1/src/hydrogen-instructions.h#newcode2645
src/hydrogen-instructions.h:2645: virtual Representation
RequiredInputRepresentation(int index) const {
On 2011/01/28 11:54:50, fschneider wrote:
I think we are not consistent with when to override this function.
Until now we
left the default implementation (Representation::None) for cases where
we don't
ever expect a conversion of the inputs.
Do you think that's a good idea? It seems like another unsafe default.
http://codereview.chromium.org/6390003/diff/1/src/hydrogen.cc
File src/hydrogen.cc (right):
http://codereview.chromium.org/6390003/diff/1/src/hydrogen.cc#newcode3524
src/hydrogen.cc:3524: int context_chain_length =
On 2011/01/27 14:00:07, antonm wrote:
should we refactor the code that builds context values chain into a
helper
method?
Yes, because we'll need it for compound assignments and count operations
too.
http://codereview.chromium.org/6390003/diff/1/src/ia32/lithium-ia32.cc
File src/ia32/lithium-ia32.cc (right):
http://codereview.chromium.org/6390003/diff/1/src/ia32/lithium-ia32.cc#newcode1682
src/ia32/lithium-ia32.cc:1682: bool skip_write_barrier =
stored_value->type().IsSmi() ||
On 2011/01/27 14:05:21, Vitaly wrote:
Add NeedsWriteBarrier predicate to HStoreContextSlot instruction like
it's done
for HStore{Named,Keyed}.
Yes, done.
http://codereview.chromium.org/6390003/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
