LGTM
http://codereview.chromium.org/6658034/diff/6001/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/6658034/diff/6001/src/arm/code-stubs-arm.cc#newcode637 src/arm/code-stubs-arm.cc:637: __ bind(¬_in_int32_range); There is a macro assembler instruction Ldrd which will eiterh use ldrd or two ldr instructions. http://codereview.chromium.org/6658034/diff/6001/src/arm/code-stubs-arm.cc#newcode664 src/arm/code-stubs-arm.cc:664: // Put implicit 1 before the mantissa part in scratch2 and The "and shift the mantissa bits to the correct position." part of the comment is repeated below. http://codereview.chromium.org/6658034/diff/6001/src/arm/code-stubs-arm.cc#newcode674 src/arm/code-stubs-arm.cc:674: // Shift mantisssa bits in high word. Two spaces after // http://codereview.chromium.org/6658034/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
