A suggestion to rename a function and move it to the MacroAssembler.
I implemented the same ecma truncation for bitwise operations using the vfp, but seeing (and as you suggested) this code manual handling will probably be faster
for non trivial cases. I'll make a few tests and use this code if it behaves better than the vfp. http://codereview.chromium.org/6658034/diff/6001/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/6658034/diff/6001/src/arm/code-stubs-arm.cc#newcode403 src/arm/code-stubs-arm.cc:403: static void ConvertNumberToInt32(MacroAssembler* masm, As mentioned before by Søren, I suggest renaming this to indicate this is a truncation. TruncateNumberToInt32? Maybe even mention that it is for ECMA bitwise operations. I also suggest moving this to the MacroAssembler. http://codereview.chromium.org/6658034/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
