The approach looks good. Waiting for the next review round...
Thanks, Vitaly http://codereview.chromium.org/6686003/diff/1/src/hydrogen.cc File src/hydrogen.cc (right): http://codereview.chromium.org/6686003/diff/1/src/hydrogen.cc#newcode4265 src/hydrogen.cc:4265: // because it is likely to generate better code. Similarly, we The comment should be updated. http://codereview.chromium.org/6686003/diff/1/src/ia32/stub-cache-ia32.cc File src/ia32/stub-cache-ia32.cc (right): http://codereview.chromium.org/6686003/diff/1/src/ia32/stub-cache-ia32.cc#newcode2138 src/ia32/stub-cache-ia32.cc:2138: if (object->IsGlobalObject()) return Heap::undefined_value(); Please document the checks. http://codereview.chromium.org/6686003/diff/1/src/ia32/stub-cache-ia32.cc#newcode2159 src/ia32/stub-cache-ia32.cc:2159: // before to call any runtime function. "to call" -> "calling"? http://codereview.chromium.org/6686003/diff/1/src/ia32/stub-cache-ia32.cc#newcode2167 src/ia32/stub-cache-ia32.cc:2167: __ mov(eax, Operand(esp, 3 * kPointerSize)); I think this could be combined with the code that reserves the space above. Maybe it could become the new ReserveSpaceForFastApiCall? Also, it'd be nice to get rid of the magic 3. http://codereview.chromium.org/6686003/diff/1/src/ia32/stub-cache-ia32.cc#newcode2170 src/ia32/stub-cache-ia32.cc:2170: // esp[2 * kPointerSize] is uninitialized, esp[3 * kPointerSize] contains Nice! But if manage to switch to using helper functions here, we can get rid of the comment. http://codereview.chromium.org/6686003/diff/1/src/ia32/stub-cache-ia32.cc#newcode2176 src/ia32/stub-cache-ia32.cc:2176: __ add(Operand(esp), Immediate(kFastApiCallArguments * kPointerSize)); New FreeSpace...? http://codereview.chromium.org/6686003/diff/1/src/ia32/stub-cache-ia32.cc#newcode2187 src/ia32/stub-cache-ia32.cc:2187: nit: Too many blank lines. http://codereview.chromium.org/6686003/diff/1/src/stub-cache.h File src/stub-cache.h (right): http://codereview.chromium.org/6686003/diff/1/src/stub-cache.h#newcode733 src/stub-cache.h:733: CallOptimization* optimization, Should work with "const CallOptimization&". http://codereview.chromium.org/6686003/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
