http://codereview.chromium.org/6686003/diff/1/src/hydrogen.cc File src/hydrogen.cc (right):
http://codereview.chromium.org/6686003/diff/1/src/hydrogen.cc#newcode4265 src/hydrogen.cc:4265: // because it is likely to generate better code. Similarly, we On 2011/03/14 15:33:10, Vitaly Repeshko wrote:
The comment should be updated.
Done. http://codereview.chromium.org/6686003/diff/1/src/ia32/stub-cache-ia32.cc File src/ia32/stub-cache-ia32.cc (right): http://codereview.chromium.org/6686003/diff/1/src/ia32/stub-cache-ia32.cc#newcode2159 src/ia32/stub-cache-ia32.cc:2159: // before to call any runtime function. On 2011/03/14 15:33:10, Vitaly Repeshko wrote:
"to call" -> "calling"?
Done. http://codereview.chromium.org/6686003/diff/1/src/ia32/stub-cache-ia32.cc#newcode2167 src/ia32/stub-cache-ia32.cc:2167: __ mov(eax, Operand(esp, 3 * kPointerSize)); On 2011/03/14 15:33:10, Vitaly Repeshko wrote:
I think this could be combined with the code that reserves the space
above.
Maybe it could become the new ReserveSpaceForFastApiCall? Also, it'd
be nice to
get rid of the magic 3.
I am not sure as eax is used as a scratch in checkprototypes. http://codereview.chromium.org/6686003/diff/1/src/ia32/stub-cache-ia32.cc#newcode2170 src/ia32/stub-cache-ia32.cc:2170: // esp[2 * kPointerSize] is uninitialized, esp[3 * kPointerSize] contains On 2011/03/14 15:33:10, Vitaly Repeshko wrote:
Nice! But if manage to switch to using helper functions here, we can
get rid of
the comment.
See above http://codereview.chromium.org/6686003/diff/1/src/ia32/stub-cache-ia32.cc#newcode2176 src/ia32/stub-cache-ia32.cc:2176: __ add(Operand(esp), Immediate(kFastApiCallArguments * kPointerSize)); On 2011/03/14 15:33:10, Vitaly Repeshko wrote:
New FreeSpace...?
Done. http://codereview.chromium.org/6686003/diff/1/src/ia32/stub-cache-ia32.cc#newcode2187 src/ia32/stub-cache-ia32.cc:2187: On 2011/03/14 15:33:10, Vitaly Repeshko wrote:
nit: Too many blank lines.
Done. http://codereview.chromium.org/6686003/diff/1/src/stub-cache.h File src/stub-cache.h (right): http://codereview.chromium.org/6686003/diff/1/src/stub-cache.h#newcode733 src/stub-cache.h:733: CallOptimization* optimization, On 2011/03/14 15:33:10, Vitaly Repeshko wrote:
Should work with "const CallOptimization&".
Well, it looks like typically v8 uses pointers, not references. I'll switch if you insist. http://codereview.chromium.org/6686003/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
