LGTM
http://codereview.chromium.org/6686003/diff/1/src/ia32/stub-cache-ia32.cc File src/ia32/stub-cache-ia32.cc (right): http://codereview.chromium.org/6686003/diff/1/src/ia32/stub-cache-ia32.cc#newcode2167 src/ia32/stub-cache-ia32.cc:2167: __ mov(eax, Operand(esp, 3 * kPointerSize)); On 2011/03/15 08:57:37, antonm wrote:
On 2011/03/14 15:33:10, Vitaly Repeshko wrote: > I think this could be combined with the code that reserves the space
above.
> Maybe it could become the new ReserveSpaceForFastApiCall? Also, it'd
be nice
to > get rid of the magic 3.
I am not sure as eax is used as a scratch in checkprototypes.
If it's a scratch, then it can be used in the reserve code. It'll be a bit nicer this way. But making a new helper from it is probably not worth it, because we can't use it in the interceptor code. http://codereview.chromium.org/6686003/diff/1/src/stub-cache.h File src/stub-cache.h (right): http://codereview.chromium.org/6686003/diff/1/src/stub-cache.h#newcode733 src/stub-cache.h:733: CallOptimization* optimization, On 2011/03/15 08:57:37, antonm wrote:
On 2011/03/14 15:33:10, Vitaly Repeshko wrote: > Should work with "const CallOptimization&".
Well, it looks like typically v8 uses pointers, not references. I'll
switch if
you insist.
I insist on every comment I write, unless marked otherwise :) I really think we should try to use C++ features when they provide more safety and don't get in the way. http://codereview.chromium.org/6686003/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
