http://codereview.chromium.org/6902104/diff/3001/test/mjsunit/function-call.js File test/mjsunit/function-call.js (right):
http://codereview.chromium.org/6902104/diff/3001/test/mjsunit/function-call.js#newcode35 test/mjsunit/function-call.js:35: // Array.prototype.toString, Why are these commented out? http://codereview.chromium.org/6902104/diff/3001/test/mjsunit/function-call.js#newcode160 test/mjsunit/function-call.js:160: assertTrue(/called on non-object/.test(e) || /Cannot convert/.test(e)); If we changed the test here to assertTrue(e instanceof TypeError); as it is for the non-generics below, then we could treat this as a normative test eventually to be migrated into Sputnik and/or test262. OTOH, I can see why you'd want to test that you're getting the diagnostic you expect. http://codereview.chromium.org/6902104/diff/3001/test/mjsunit/function-call.js#newcode164 test/mjsunit/function-call.js:164: should_throw_on_null_and_undefined[i].call(undefined); If should_throw_on_null_and_undefined[i] happens to be a function that expects more arguments and throws if these are absent, then calling it without the rest of its expected arguments is not a reliable test that you're getting the error for the right reason. http://codereview.chromium.org/6902104/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
