LGTM
http://codereview.chromium.org/6902104/diff/3001/test/mjsunit/function-call.js File test/mjsunit/function-call.js (right): http://codereview.chromium.org/6902104/diff/3001/test/mjsunit/function-call.js#newcode149 test/mjsunit/function-call.js:149: Array.prototype.reduceRight]; No, but I think we should use undefined for strict functions, and not always the global receiver. http://codereview.chromium.org/6902104/diff/9001/test/mjsunit/function-call.js#newcode160 test/mjsunit/function-call.js:160: assertTrue(/called on non-object/.test(e) || /Cannot convert/.test(e)); We call all functions with no parameters, which means that essential parameters will have the undefined value. The test for whether the "this" value is null or undefined is always performed before access to the other parameters, so even if the undefined value is an invalid argument value, it mustn't change the result of the test. http://codereview.chromium.org/6902104/diff/9001/test/mjsunit/function-call.js#newcode238 test/mjsunit/function-call.js:238: assertUnreachable(); How about explicitly converting e to a string before doing regexp test on it. Can we test the e.type property directly? http://codereview.chromium.org/6902104/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
