Please have another look:
Addressed comments
Changed Array.prototype.toString and toLocaleString to only work on arrays
(filled bug: http://code.google.com/p/v8/issues/detail?id=1361)
Removed not passing tests from es5conform and sputnik
Added test exception to mozilla status (double checked that firefox nightly
is
also throwing on this)
http://codereview.chromium.org/6902104/diff/3001/test/mjsunit/function-call.js
File test/mjsunit/function-call.js (right):
http://codereview.chromium.org/6902104/diff/3001/test/mjsunit/function-call.js#newcode149
test/mjsunit/function-call.js:149: Array.prototype.reduceRight];
On 2011/05/03 09:01:02, Lasse Reichstein wrote:
No, but I think we should use undefined for strict functions, and not
always the
global receiver.
Bug filled for this and Array.prototype.sort
http://code.google.com/p/v8/issues/detail?id=1360
http://codereview.chromium.org/6902104/diff/9001/test/mjsunit/function-call.js#newcode160
test/mjsunit/function-call.js:160: assertTrue(/called on
non-object/.test(e) || /Cannot convert/.test(e));
On 2011/05/03 09:01:03, Lasse Reichstein wrote:
We call all functions with no parameters, which means that essential
parameters
will have the undefined value.
The test for whether the "this" value is null or undefined is always
performed
before access to the other parameters, so even if the undefined value
is an
invalid argument value, it mustn't change the result of the test.
Done.
http://codereview.chromium.org/6902104/diff/9001/test/mjsunit/function-call.js#newcode238
test/mjsunit/function-call.js:238: assertUnreachable();
On 2011/05/03 09:01:03, Lasse Reichstein wrote:
How about explicitly converting e to a string before doing regexp test
on it.
Can we test the e.type property directly?
Done.
http://codereview.chromium.org/6902104/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
