http://codereview.chromium.org/7058009/diff/1/src/spaces.h File src/spaces.h (right):
http://codereview.chromium.org/7058009/diff/1/src/spaces.h#newcode1472 src/spaces.h:1472: void CopyFlagsFrom(NewSpacePage* chunk) { This is called CopyFlagsFrom, but it only copies one flag. I think the name should be singular rather than plural and should include the flag that is copied. http://codereview.chromium.org/7058009/diff/1/src/spaces.h#newcode1560 src/spaces.h:1560: if (o->IsSmi()) { this is SemiSpace::Contains(), but I think what we actually need (perhaps outside of ASSERTs) is an Object::InFromSpace() and an Object::InToSpace(). This can be implemented with one memory read (from the page) rather than two (one to get the id of the semispace and one to get the bit from the page). It's pretty performance critical in scavenging, so I think it's worth the bother of flipping the bits after a scavenge. http://codereview.chromium.org/7058009/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
