http://codereview.chromium.org/7058009/diff/3001/src/spaces.cc File src/spaces.cc (right):
http://codereview.chromium.org/7058009/diff/3001/src/spaces.cc#newcode1154 src/spaces.cc:1154: is_to_space_ = !is_to_space_; This can be written in terms of GetFlag and SetFlag for more clarity. http://codereview.chromium.org/7058009/diff/3001/src/spaces.h File src/spaces.h (right): http://codereview.chromium.org/7058009/diff/3001/src/spaces.h#newcode379 src/spaces.h:379: IN_TO_SPACE, // Only used if IN_NEW_SPACE is set. Instead of a TO_SPACE flag and a FROM_SPACE flag I would suggest a TO_SPACE and a FROM_SPACE flag. http://codereview.chromium.org/7058009/diff/3001/src/spaces.h#newcode1627 src/spaces.h:1627: bool is_to_space_; This should be a SemiSpaceId instead of a bool http://codereview.chromium.org/7058009/diff/3001/src/spaces.h#newcode1853 src/spaces.h:1853: MemoryChunk* page = MemoryChunk::FromAddress(address); assert it is a new space page and the same in FromSpaceContains. http://codereview.chromium.org/7058009/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
