http://codereview.chromium.org/7058009/diff/3001/src/spaces.cc File src/spaces.cc (right):
http://codereview.chromium.org/7058009/diff/3001/src/spaces.cc#newcode949 src/spaces.cc:949: (1 << MemoryChunk::SCAN_ON_SCAVENGE); Reduced and added as constant in NewSpacePage. http://codereview.chromium.org/7058009/diff/3001/src/spaces.cc#newcode1154 src/spaces.cc:1154: is_to_space_ = !is_to_space_; No, it works on the "flags" argument, not the "flags_" field. http://codereview.chromium.org/7058009/diff/3001/src/spaces.h File src/spaces.h (right): http://codereview.chromium.org/7058009/diff/3001/src/spaces.h#newcode379 src/spaces.h:379: IN_TO_SPACE, // Only used if IN_NEW_SPACE is set. Done. http://codereview.chromium.org/7058009/diff/3001/src/spaces.h#newcode1627 src/spaces.h:1627: bool is_to_space_; Done. http://codereview.chromium.org/7058009/diff/3001/src/spaces.h#newcode1853 src/spaces.h:1853: MemoryChunk* page = MemoryChunk::FromAddress(address); Are we sure it is a new-space address? This also works, returning false, for old-space addresses. http://codereview.chromium.org/7058009/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
