http://codereview.chromium.org/7112010/diff/2014/src/arm/lithium-arm.cc File src/arm/lithium-arm.cc (right):
http://codereview.chromium.org/7112010/diff/2014/src/arm/lithium-arm.cc#newcode2002 src/arm/lithium-arm.cc:2002: bool val_is_temp_register = elements_kind == (elements_kind == A) || (elements_kind == B) ? http://codereview.chromium.org/7112010/diff/2014/src/arm/stub-cache-arm.cc File src/arm/stub-cache-arm.cc (right): http://codereview.chromium.org/7112010/diff/2014/src/arm/stub-cache-arm.cc#newcode3435 src/arm/stub-cache-arm.cc:3435: case JSObject::EXTERNAL_PIXEL_ELEMENTS: Are pixel values signed? I didn't think so. It seems that pixel arrays were not handled here before. Can this just go in the unhandled part? http://codereview.chromium.org/7112010/diff/2014/src/arm/stub-cache-arm.cc#newcode3518 src/arm/stub-cache-arm.cc:3518: case JSObject::EXTERNAL_DOUBLE_ELEMENTS: Something is off with the indentation I think? http://codereview.chromium.org/7112010/diff/2014/src/heap.h File src/heap.h (right): http://codereview.chromium.org/7112010/diff/2014/src/heap.h#newcode138 src/heap.h:138: #define SYMBOL_LIST(V) \ Is there any actual change here? http://codereview.chromium.org/7112010/diff/2014/src/lithium.cc File src/lithium.cc (right): http://codereview.chromium.org/7112010/diff/2014/src/lithium.cc#newcode187 src/lithium.cc:187: return kPointerSizeLog2; For DoubleElements you should multiply by the size of a double and not by the size of a pointer, right? Or am I missing something in the way this is used? http://codereview.chromium.org/7112010/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
