Feedback addressed, please take another look.
http://codereview.chromium.org/7112010/diff/2014/src/arm/lithium-arm.cc
File src/arm/lithium-arm.cc (right):
http://codereview.chromium.org/7112010/diff/2014/src/arm/lithium-arm.cc#newcode2002
src/arm/lithium-arm.cc:2002: bool val_is_temp_register = elements_kind
==
On 2011/06/09 14:15:45, Mads Ager wrote:
(elements_kind == A) || (elements_kind == B)
?
Done.
http://codereview.chromium.org/7112010/diff/2014/src/arm/lithium-codegen-arm.cc
File src/arm/lithium-codegen-arm.cc (right):
http://codereview.chromium.org/7112010/diff/2014/src/arm/lithium-codegen-arm.cc#newcode2637
src/arm/lithium-codegen-arm.cc:2637: } else { // i.e. array_type ==
kExternalDoubleArray
On 2011/06/09 14:26:40, jkummerow wrote:
please update this comment.
Done.
http://codereview.chromium.org/7112010/diff/2014/src/arm/lithium-codegen-arm.cc#newcode3453
src/arm/lithium-codegen-arm.cc:3453: } else { // i.e. array_type ==
kExternalDoubleArray
On 2011/06/09 14:26:40, jkummerow wrote:
please update this comment.
Done.
http://codereview.chromium.org/7112010/diff/2014/src/arm/stub-cache-arm.cc
File src/arm/stub-cache-arm.cc (right):
http://codereview.chromium.org/7112010/diff/2014/src/arm/stub-cache-arm.cc#newcode3435
src/arm/stub-cache-arm.cc:3435: case JSObject::EXTERNAL_PIXEL_ELEMENTS:
On 2011/06/09 14:15:45, Mads Ager wrote:
Are pixel values signed? I didn't think so. It seems that pixel arrays
were not
handled here before. Can this just go in the unhandled part?
Done.
http://codereview.chromium.org/7112010/diff/2014/src/arm/stub-cache-arm.cc#newcode3435
src/arm/stub-cache-arm.cc:3435: case JSObject::EXTERNAL_PIXEL_ELEMENTS:
On 2011/06/09 14:26:40, jkummerow wrote:
really?
Done.
http://codereview.chromium.org/7112010/diff/2014/src/arm/stub-cache-arm.cc#newcode3518
src/arm/stub-cache-arm.cc:3518: case JSObject::EXTERNAL_DOUBLE_ELEMENTS:
On 2011/06/09 14:15:45, Mads Ager wrote:
Something is off with the indentation I think?
Done.
http://codereview.chromium.org/7112010/diff/2014/src/heap.h
File src/heap.h (right):
http://codereview.chromium.org/7112010/diff/2014/src/heap.h#newcode138
src/heap.h:138: #define SYMBOL_LIST(V)
\
On 2011/06/09 14:15:45, Mads Ager wrote:
Is there any actual change here?
Done. Removed non-relevant white-space changes.
http://codereview.chromium.org/7112010/diff/2014/src/heap.h#newcode138
src/heap.h:138: #define SYMBOL_LIST(V)
\
On 2011/06/09 14:26:40, jkummerow wrote:
what exactly is the change here?
Done.
http://codereview.chromium.org/7112010/diff/2014/src/lithium.cc
File src/lithium.cc (right):
http://codereview.chromium.org/7112010/diff/2014/src/lithium.cc#newcode185
src/lithium.cc:185: case JSObject::FAST_DOUBLE_ELEMENTS:
On 2011/06/09 14:26:40, jkummerow wrote:
FAST_DOUBLE_ELEMENTS should return 3
Done.
http://codereview.chromium.org/7112010/diff/2014/src/lithium.cc#newcode187
src/lithium.cc:187: return kPointerSizeLog2;
Not used yet, but you're right,
On 2011/06/09 14:15:45, Mads Ager wrote:
For DoubleElements you should multiply by the size of a double and not
by the
size of a pointer, right? Or am I missing something in the way this is
used?
http://codereview.chromium.org/7112010/diff/2014/src/type-info.cc
File src/type-info.cc (right):
http://codereview.chromium.org/7112010/diff/2014/src/type-info.cc#newcode174
src/type-info.cc:174: JSObject::ElementsKind
TypeFeedbackOracle::GetKeyedLoadElementsKind(
On 2011/06/09 14:26:40, jkummerow wrote:
See the comment in type-info.h -- I think you can remove
GetKeyed{Load,Store}ElementsKind().
Done.
http://codereview.chromium.org/7112010/diff/2014/src/type-info.h
File src/type-info.h (right):
http://codereview.chromium.org/7112010/diff/2014/src/type-info.h#newcode231
src/type-info.h:231: JSObject::ElementsKind
GetKeyedLoadElementsKind(Property* expr);
On 2011/06/09 14:26:40, jkummerow wrote:
I believe these two methods can be removed completely. AFAICS they've
only been
used in ast.cc, and you've removed those occurrences.
Done.
http://codereview.chromium.org/7112010/
--
v8-dev mailing list
[email protected]
http://groups.google.com/group/v8-dev
