Some of my comments are dupes of Mads' comments; I couldn't be bothered to filter them out :-)
http://codereview.chromium.org/7112010/diff/2014/src/arm/lithium-codegen-arm.cc File src/arm/lithium-codegen-arm.cc (right): http://codereview.chromium.org/7112010/diff/2014/src/arm/lithium-codegen-arm.cc#newcode2637 src/arm/lithium-codegen-arm.cc:2637: } else { // i.e. array_type == kExternalDoubleArray please update this comment. http://codereview.chromium.org/7112010/diff/2014/src/arm/lithium-codegen-arm.cc#newcode3453 src/arm/lithium-codegen-arm.cc:3453: } else { // i.e. array_type == kExternalDoubleArray please update this comment. http://codereview.chromium.org/7112010/diff/2014/src/arm/stub-cache-arm.cc File src/arm/stub-cache-arm.cc (right): http://codereview.chromium.org/7112010/diff/2014/src/arm/stub-cache-arm.cc#newcode3435 src/arm/stub-cache-arm.cc:3435: case JSObject::EXTERNAL_PIXEL_ELEMENTS: really? http://codereview.chromium.org/7112010/diff/2014/src/heap.h File src/heap.h (right): http://codereview.chromium.org/7112010/diff/2014/src/heap.h#newcode138 src/heap.h:138: #define SYMBOL_LIST(V) \ what exactly is the change here? http://codereview.chromium.org/7112010/diff/2014/src/lithium.cc File src/lithium.cc (right): http://codereview.chromium.org/7112010/diff/2014/src/lithium.cc#newcode185 src/lithium.cc:185: case JSObject::FAST_DOUBLE_ELEMENTS: FAST_DOUBLE_ELEMENTS should return 3 http://codereview.chromium.org/7112010/diff/2014/src/type-info.cc File src/type-info.cc (right): http://codereview.chromium.org/7112010/diff/2014/src/type-info.cc#newcode174 src/type-info.cc:174: JSObject::ElementsKind TypeFeedbackOracle::GetKeyedLoadElementsKind( See the comment in type-info.h -- I think you can remove GetKeyed{Load,Store}ElementsKind(). http://codereview.chromium.org/7112010/diff/2014/src/type-info.h File src/type-info.h (right): http://codereview.chromium.org/7112010/diff/2014/src/type-info.h#newcode231 src/type-info.h:231: JSObject::ElementsKind GetKeyedLoadElementsKind(Property* expr); I believe these two methods can be removed completely. AFAICS they've only been used in ast.cc, and you've removed those occurrences. http://codereview.chromium.org/7112010/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
