This version of NaN handling is not going to work since NaN is not equal to anything. The rest of the V8 usage looks fine.
http://codereview.chromium.org/7129051/diff/3001/src/extensions/experimental/number-format.cc File src/extensions/experimental/number-format.cc (right): http://codereview.chromium.org/7129051/diff/3001/src/extensions/experimental/number-format.cc#newcode90 src/extensions/experimental/number-format.cc:90: if (value == nan_) { This does not work. NaN is not equal to anything so this should always be false. Have you tested this? You do need a is_nan method here. Most platforms provide one directly and windows has is_nan_. Can you introduce a i18n-extension-utils.h file that does the right platform #ifdef magic to make a is_nan method available on all platforms? http://codereview.chromium.org/7129051/diff/3001/src/extensions/experimental/number-format.h File src/extensions/experimental/number-format.h (right): http://codereview.chromium.org/7129051/diff/3001/src/extensions/experimental/number-format.h#newcode58 src/extensions/experimental/number-format.h:58: void* param); Indentation is a bit off. http://codereview.chromium.org/7129051/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
