Sorry, I was away Fri-Mon. Not ready for another review.
I'll add currencyCode (to match update in the docs) to the settings and then ask
for another round. http://codereview.chromium.org/7129051/diff/3001/src/extensions/experimental/number-format.cc File src/extensions/experimental/number-format.cc (right): http://codereview.chromium.org/7129051/diff/3001/src/extensions/experimental/number-format.cc#newcode90 src/extensions/experimental/number-format.cc:90: if (value == nan_) { ICU can handle NaN properly so I've removed hacky code. On 2011/06/10 07:25:30, Mads Ager wrote:
This does not work. NaN is not equal to anything so this should always
be false.
Have you tested this?
You do need a is_nan method here. Most platforms provide one directly
and
windows has is_nan_. Can you introduce a i18n-extension-utils.h file
that does
the right platform #ifdef magic to make a is_nan method available on
all
platforms?
http://codereview.chromium.org/7129051/diff/3001/src/extensions/experimental/number-format.h File src/extensions/experimental/number-format.h (right): http://codereview.chromium.org/7129051/diff/3001/src/extensions/experimental/number-format.h#newcode58 src/extensions/experimental/number-format.h:58: void* param); On 2011/06/10 07:25:30, Mads Ager wrote:
Indentation is a bit off.
Done. http://codereview.chromium.org/7129051/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
