LGTM with nits below taken care of.
http://codereview.chromium.org/7129051/diff/19003/src/extensions/experimental/number-format.cc File src/extensions/experimental/number-format.cc (right): http://codereview.chromium.org/7129051/diff/19003/src/extensions/experimental/number-format.cc#newcode250 src/extensions/experimental/number-format.cc:250: // Find how many U+00A4 are there. There is at least one. nit: Add a comment that non-consecutive U+00A4's have been taken care of in i18n.js http://codereview.chromium.org/7129051/diff/19003/src/extensions/experimental/number-format.cc#newcode347 src/extensions/experimental/number-format.cc:347: return true; nit: You can combine the above 4 lines to "return !!U_SUCCESS(status);" http://codereview.chromium.org/7129051/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
