LGTM
http://codereview.chromium.org/7282026/diff/7018/src/arm/code-stubs-arm.cc File src/arm/code-stubs-arm.cc (right): http://codereview.chromium.org/7282026/diff/7018/src/arm/code-stubs-arm.cc#newcode4425 src/arm/code-stubs-arm.cc:4425: __ b(ne, &runtime); This b is superfluous http://codereview.chromium.org/7282026/diff/7018/src/ia32/code-stubs-ia32.cc File src/ia32/code-stubs-ia32.cc (right): http://codereview.chromium.org/7282026/diff/7018/src/ia32/code-stubs-ia32.cc#newcode3385 src/ia32/code-stubs-ia32.cc:3385: __ j(not_equal, &runtime); This j is superfluous. http://codereview.chromium.org/7282026/diff/7018/src/jsregexp.cc File src/jsregexp.cc (right): http://codereview.chromium.org/7282026/diff/7018/src/jsregexp.cc#newcode298 src/jsregexp.cc:298: // We could potentially have marked this as flushable, but have keept keept -> kept http://codereview.chromium.org/7282026/diff/7018/src/mark-compact.cc File src/mark-compact.cc (right): http://codereview.chromium.org/7282026/diff/7018/src/mark-compact.cc#newcode733 src/mark-compact.cc:733: if (value == (heap->sweep_generation() - kRegExpCodeThreshold) % 256) { If the lhs is negative then according to the standard the result of the % operator can be either positive or negative. Therefore I would prefer using & 0xff which can yield only a positive answer. The same applies above. http://codereview.chromium.org/7282026/diff/7018/src/objects-debug.cc File src/objects-debug.cc (right): http://codereview.chromium.org/7282026/diff/7018/src/objects-debug.cc#newcode472 src/objects-debug.cc:472: ASSERT(ascii_data->IsSmi() || ascii_data->IsJSObject() || I can see that it was already there before, but it is not clear to me how this can be a JSObject? http://codereview.chromium.org/7282026/diff/7018/src/objects-debug.cc#newcode478 src/objects-debug.cc:478: Object* ascii_saved = arr->get(JSRegExp::kIrregexpUC16CodeSavedIndex); Should be the ASCII index here. http://codereview.chromium.org/7282026/diff/7018/src/objects-inl.h File src/objects-inl.h (right): http://codereview.chromium.org/7282026/diff/7018/src/objects-inl.h#newcode3914 src/objects-inl.h:3914: fa->set_unchecked(heap, index, value, UPDATE_WRITE_BARRIER); I think this is OK, but I would like to ask Slava. http://codereview.chromium.org/7282026/diff/7018/src/objects-visiting.h File src/objects-visiting.h (right): http://codereview.chromium.org/7282026/diff/7018/src/objects-visiting.h#newcode304 src/objects-visiting.h:304: table_.Register(kVisitJSRegExp, Fits on one line. http://codereview.chromium.org/7282026/diff/7018/src/objects.h File src/objects.h (right): http://codereview.chromium.org/7282026/diff/7018/src/objects.h#newcode5297 src/objects.h:5297: // used for tracking the last usage (used for code flushing).. Missing description of the 'saved' fields. http://codereview.chromium.org/7282026/diff/7018/src/x64/code-stubs-x64.cc File src/x64/code-stubs-x64.cc (right): http://codereview.chromium.org/7282026/diff/7018/src/x64/code-stubs-x64.cc#newcode2460 src/x64/code-stubs-x64.cc:2460: __ j(not_equal, &runtime); Hat trick! http://codereview.chromium.org/7282026/ -- v8-dev mailing list [email protected] http://groups.google.com/group/v8-dev
